Re: [libvirt] [PATCH 4/8] qemu: Allow to undefine a running domain

On 08/19/2011 08:03 AM, Osier Yang wrote:

--- src/qemu/qemu_driver.c | 22 +++++++++++++--------- 1 files changed, 13 insertions(+), 9 deletions(-)

ACK with nit.

VIR_INFO("Undefining domain '%s'", vm->def->name); - virDomainRemoveInactive(&driver->domains, - vm); - vm = NULL; + + /* If the domain is active, keep it running but set it as transient. + * domainDestroy and domainShutdown will take care of remove the

s/remove/removing/ -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org