Re: [libvirt] [PATCH 09/10 v5] list: Use virConnectListAllStoragePools in virsh
On 09/05/2012 12:52 PM, Eric Blake wrote:
On 09/05/2012 12:36 AM, Osier Yang wrote:
> +++ b/tools/virsh-pool.c
> @@ -36,6 +36,7 @@
> #include "memory.h"
> #include "util.h"
> #include "xml.h"
> +#include "conf/storage_conf.h"
I'm not sure if virsh is supposed to be able to use conf/*.h files;
you're not the first offender, but the more we do this, the more we are
admitting that our public API is insufficient. I'm wondering if we
should move the filter group constants into libvirt.h, and make them
part of the public API...
Yes. (or whatever it takes to not use non-public .h files in virsh).
virsh should only use the public libvirt API; if it needs something
that's private to libvirt, either that piece of code should be
rewritten, or the public API should be enhanced. (But, as you say, Osier
isn't the first offender, so it's okay to let this temporarily slip by).