Re: [libvirt] [PATCH v3 05/12] qemu: Auto add pci-root for s390/s390x guests

On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote: > The pci-root depends on zpci capability. So autogenerate pci-root if > zpci exists. > > Signed-off-by: Yi Min Zhao <zyimin(a)linux.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > Reviewed-by: Stefan Zimmermann <stzi(a)linux.ibm.com&gt; > Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com&gt; > Reviewed-by: Ján Tomko <jtomko(a)redhat.com&gt; > --- > src/qemu/qemu_domain.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index de056272e8..a84e5f06b2 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -3227,6 +3227,7 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def, > case VIR_ARCH_S390X: > addDefaultUSB = false; > addPanicDevice = true; > + addPCIRoot = virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_ZPCI); > break; I wonder if you might want to do this, and other stuff, only if qemuDomainIsS390CCW()... It seems like that function is not used a lot, which might mean that someone is going to have to perform some serious cleaning up if there is ever another machine type on s390, or perhaps that it just doesn't quite apply here.

If the latter, Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt;