Re: [libvirt] [libvirt-python][PATCH] maint: Require libvirt-3.4.0 at least
On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote:
Currently, we require 0.9.11. However, some APIs are missing
there and thus sanity check fails:
DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7
/usr/share/libvirt/api/libvirt-api.xml
DEBUG: FAIL virStream.sparseRecvAll (Python API not mapped to C)
DEBUG: FAIL virStream.sparseSendAll (Python API not mapped to C)
DEBUG: error: command '/usr/bin/python' failed with exit status 1
I'm not sure how to fix that so raising minimal required libvirt
version is the solution.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
setup.py | 2 +-
README | 2 +-
libvirt-override.c | 149 -----------------------------------------------------
3 files changed, 2 insertions(+), 151 deletions(-)
diff --git a/setup.py b/setup.py
index f33ff1a..f929eb2 100755
--- a/setup.py
+++ b/setup.py
@@ -17,7 +17,7 @@ import re
import shutil
import time
-MIN_LIBVIRT = "0.9.11"
+MIN_LIBVIRT = "3.4.0"
NACK, we cannot do this - it will break many people and apps (OpenStack
in particular) who expect latest libvirt on pypi to work with historical
C libs.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|