Eric Blake <eblake@redhat.com> wrote on 03/03/2014 02:42:57 PM:

> From: Eric Blake <eblake@redhat.com>

> To: Stefan Berger/Watson/IBM@IBMUS, libvir-list@redhat.com,
> Cc: laine@laine.org
> Date: 03/03/2014 02:43 PM
> Subject: Re: [libvirt] [PATCH 1/3] nwfilter: Cap the poll timeout in
> the DHCP Snooping code

>
> On 03/02/2014 09:34 PM, Stefan Berger wrote:
> > From: Stefan Berger <stefanb@linux.vnet.ibm.com>
> >
> > Cap the poll timeout in the DHCP Snooping code to a max. of 10 seconds
> > to not hold up the libvirt shutdown longer than this.
> >
> > Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> > ---
> >  src/nwfilter/nwfilter_dhcpsnoop.c | 5 +++++
> >  1 file changed, 5 insertions(+)
>
> I'm assuming you've tested that the code gracefully handles a timeout
> failure?


Timeout failer = returns with return code '0' from poll(). This is gracefully handled by the code.

   Stefan