Re: [libvirt] [PATCH 15/21] caps2xml resctrl-skx-twocaches
On Tue, Nov 14, 2017 at 04:20:45PM -0500, John Ferlan wrote:
Would be nice to have more information here regarding what this is....
Only after sending have I found out that I somehow missed few commits when
adding commit messages. This is one of the examples, another one is "conf:
cachetune". I can resend part of the series or just add it as a reply to the
mail if you want.
It seems this is just some new test... It works, but does it add to
test bloat? Could it be merged into existing skx test? IOW: does the
existing test "need" to have just one bank? I'm OK with the separate
test, but I guess it's just not clear why there needs to be a separate
one (I could have missed something subtle too). In any case -
For example the commit message that's missing here would say that this
particular test data actually make future test from patch 19 to have more
coverage. There are test cases with comments on why particular cases should
fail and I wanted to cover all obvious failures with only a few system<->domain
combinations. I would have to find the table and the matrix of all of them that
I wrote somewhere on a paper to tell you why exactly this one is needed, but it
is written somewhere, maybe it's just in trash =D
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
[apologies for the "timeliness" of reviews - it's been a distracting
day... Sometimes it's more worthwhile to just turn off IRC ;-)]
No need to apologize, it's very fast review, I thought I will not get any for
couple of weeks =D
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)