Re: [libvirt] [PATCH 17/23] cputest: Add query-cpu-definitions reply for Core-i5-2540M
On Thu, Oct 12, 2017 at 17:49:33 -0400, John Ferlan wrote:
On 10/04/2017 10:58 AM, Jiri Denemark wrote:
> The unavailable features do not make any difference in this case,
> because this is a SandyBridge CPU which has an empty list of unavailable
> features.
...
> diff --git a/tests/cputestdata/x86_64-cpuid-Core-i5-2540M.json
b/tests/cputestdata/x86_64-cpuid-Core-i5-2540M.json
> index d813326f6f..a8ed64ed63 100644
> --- a/tests/cputestdata/x86_64-cpuid-Core-i5-2540M.json
> +++ b/tests/cputestdata/x86_64-cpuid-Core-i5-2540M.json
[...]
> + {
> + "typename": "Skylake-Client-x86_64-cpu",
> + "unavailable-features": [
...
> + "mpx",
> + "mpx"
Is this a typo or bad cut-n-paste - "mpx" three times in the list?
It looks like a bug in QEMU since this is just a copy of real QEMU's
reply on a host with this CPU. Some unavailable features appear more
that once in the list (you can see it the following patches too). We
don't care as long as each unavailable feature is there at least once.
Jirka