On 05/07/2018 10:41 AM, Boris Fiuczynski wrote:
From: Shalini Chellathurai Saroja <shalini@linux.vnet.ibm.com>
Introduces the vfio-ccw model for mediated devices and prime vfio-ccw devices such that CCW address will be generated.
Signed-off-by: Shalini Chellathurai Saroja <shalini@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bwalk@linux.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com> Reviewed-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com> Reviewed-by: Stefan Zimmermann <stzi@linux.ibm.com> --- docs/schemas/domaincommon.rng | 5 ++++- src/qemu/qemu_domain_address.c | 20 ++++++++++++++++++++ src/util/virmdev.c | 3 ++- src/util/virmdev.h | 1 + 4 files changed, 27 insertions(+), 2 deletions(-)
Looking at all places using VIR_MDEV_MODEL_TYPE_VFIO_PCI - should this patch make a change to virDomainHostdevDefPostParse to do something similar - that is: if (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { ... error message } ? Let me know... I think it should and can add it before pushing... Reviewed-by: John Ferlan <jferlan@redhat.com> John