Re: [libvirt PATCH 4/4] qemu: virtiofs: use a .log.fs suffix for logs

On a Monday in 2020, Daniel P. Berrangé wrote: > On Mon, Mar 23, 2020 at 05:10:37PM +0100, Ján Tomko wrote: > > As Dave pointed out, someone creative might name a domain > > to make its logfile conflict with a logfile of another > > domain's virtiofsd log. > > > > Signed-off-by: Ján Tomko <jtomko(a)redhat.com&gt; > > Reported-by: Dr. David Alan Gilbert <dgilbert(a)redhat.com&gt; > > --- > > src/qemu/qemu_virtiofs.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c > > index aaa25bcbb8..575b47fd74 100644 > > --- a/src/qemu/qemu_virtiofs.c > > +++ b/src/qemu/qemu_virtiofs.c > > @@ -67,9 +67,9 @@ qemuVirtioFSCreateLogFilename(virQEMUDriverConfigPtr cfg, > > { > > g_autofree char *name = NULL; > > > > - name = g_strdup_printf("%s-%s", def->name, alias); > > + name = g_strdup_printf("%s-%s.log.fs", def->name, alias); > > Having a logfile that doesn't end in ".log" is pretty gross IMHO Agreed. > and will mean it isn't caught by logrotate matching *.log I did not realize that. > > Can't we deal with the clash in another way that preserves .log as a > suffix Not in the same directory, but I can create a separate directory, something like: /var/log/libvirt/qemu/vhost-user/%{name}-fs-%{alias}.log /var/log/libvirt/qemu/devices/%{name}-fs-%{alias}.log /var/log/libvirt/qemu/fs/%{name}-%{alias}.log