Re: [libvirt] [PATCH] shutting down guest vms on host shutdown does not work
On 07/30/2012 02:42 AM, Gerd v. Egidy wrote:
Hi Eric,
> Thanks for researching this! ACK and applied.
Thanks.
> Now a followup question - in AUTHORS, you are listed as Gerd von Egidy,
> but in this commit, your authorship is Gerd v. Egidy. Which do you
> prefer, and I'll update .mailmap and possibly AUTHORS (it makes it so
> that 'git shortlog' will bundle all commits by you under a single
> listing of your preferred spelling).
You seem to care about crediting your contributors - nice.
I personally find that showing a bit of gratitude to infrequent
contributors can go a long way - open source is more than just the code,
it is also the positive social aspects that it can foster :)
[Then there are the legal folks that say that properly tracking
contributions makes it easier to defend against litigation - but that
reason for maintaining 'AUTHORS' doesn't have quite the positive
connotations as a belief in a society built on decency. :) ]
I think I should consolidate all my email addresses an git default configs, but
until that is done you can apply the attached patch.
Applied, and thanks again.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)