On 09/09/2013 01:43 PM, Doug Goldstein wrote:
On Mon, Sep 9, 2013 at 2:12 PM, Eric Blake <eblake@redhat.com> wrote:
Osier Yang pointed out that ever since commit 31cb030, the signature of qemuDomainObjEndJob was changed to return a bool. While comparison against 0 or > 0 still gives the right results, it looks fishy; we also had one place that was comparing < 0 which is effectively dead code.
* src/qemu/qemu_migration.c (qemuMigrationPrepareAny): Fix dead code bug.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
Most of this is mechanical, but the change to qemuMigrationPrepareAny requires special care to ensure that checking for 0 instead of negative isn't introducing a bug on failure to start incoming migration.
ACK. Looked fairly mechanical. Only thing I had to check was the goto cleanup going away in a few places and it was all correct.
Thanks; pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org