Re: [libvirt] [PATCH 1/3] Domain events - primary implementation

On Thu, Oct 09, 2008 at 11:22:38AM -0400, Ben Guthro wrote: > diff --git a/src/internal.h b/src/internal.h > index a3d48fa..67a3e5b 100644 > --- a/src/internal.h > +++ b/src/internal.h > @@ -191,6 +191,18 @@ extern int debugFlag; > #define VIR_IS_STORAGE_VOL(obj) ((obj) && (obj)->magic==VIR_STORAGE_VOL_MAGIC) > #define VIR_IS_CONNECTED_STORAGE_VOL(obj) (VIR_IS_STORAGE_VOL(obj) && VIR_IS_CONNECT((obj)->conn)) > > +/** > + * Domain Event Callbacks > + */ > +struct _virDomainEventCallbackList { > + virConnectPtr conn; > + virConnectDomainEventCallback cb; > + void *opaque; > + struct _virDomainEventCallbackList *next; > +}; > + > +typedef struct _virDomainEventCallbackList virDomainEventCallbackList; > + > /* > * arbitrary limitations > */ > @@ -237,6 +249,12 @@ struct _virConnect { > virHashTablePtr storagePools;/* hash table for known storage pools */ > virHashTablePtr storageVols;/* hash table for known storage vols */ > int refs; /* reference count */ > + > + /* Domain Callbacks */ > + virDomainEventCallbackList *domainEventCallbacks; > + > + /* link to next conn of this driver type */ > + struct _virConnect *next; > }; This doesn't make any sense to me - you're making all the virConnect objects cross reference each other. Each object only needs to know about the callbacks registered to itself - it doesn't care about callbacks other virConnect objects have. I'd expect something more like struct _virDomainEventCallback { virConnectDomainEventCallback cb; void *opaque; }; typedef struct _virDomainEventCallback virDomainEventCallback; typedef virDomainEventCallback *virDomainEventCallbackPtr; struct _virDomainEventCallbackList { unsigned int ndomainCallbacks; struct __virDomainEventCallbackPtr *domainCallbacks; } typedef struct _virDomainEventCallbackList virDomainEventCallbackList; I used a explicit array here, because we're trying to kill off the linked lists, since it simplifies thread safety work, to be able to lock individual objects, and not worry about its peers pointing to it - only its parent. The internal drivers would then have virDomainEventCallbackList intances as they need - eg, in the _xenUnifiedPrivate struct for Xen drivers, or in the 'struct qemud_driver' for QEMU, etc.