Re: [Libvir] avoid reading uninitialized memory in test program
On Thu, Oct 18, 2007 at 09:18:20AM -0400, Daniel Veillard wrote:
On Wed, Oct 17, 2007 at 01:34:21PM +0200, Jim Meyering wrote:
> valgrind complained about the printf in conftest.c.
> Here's the fix:
>
> * src/conf.c (__virConfWriteMem): Fix typos in comment.
> * tests/conftest.c (main): Use fwrite, not printf, since the
> result buffer is not NUL-terminated.
Patch looks fine to me,
commited to CVS,
thanks Jim !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/