Re: [libvirt] [PATCH 3/3] storage: Split out volume upload/download as separate backend function

On 07/10/2014 08:30 AM, Peter Krempa wrote: > For non-local storage drivers we can't expect to use the FDStream > backend for up/downloading volumes. Split the code into a separate > backend function so that we can add protocol specific code later. > --- > src/storage/storage_backend.c | 31 +++++++++++++++++++++++ > src/storage/storage_backend.h | 30 ++++++++++++++++++++++ > src/storage/storage_backend_disk.c | 2 ++ > src/storage/storage_backend_fs.c | 7 ++++++ > src/storage/storage_backend_iscsi.c | 2 ++ > src/storage/storage_backend_logical.c | 2 ++ > src/storage/storage_backend_mpath.c | 2 ++ > src/storage/storage_backend_scsi.c | 2 ++ > src/storage/storage_driver.c | 47 +++++++++++------------------------ > 9 files changed, 93 insertions(+), 32 deletions(-) Without even reading this patch yet, this is more the approach I had in mind for 2/3.