Re: [libvirt] [PATCH v3 8/8] libxl: implement virDomainGetJobStats

On 12/03/2015 06:48 PM, Jim Fehlig wrote: > Joao Martins wrote: >> Introduces support for domainGetJobStats which has the same >> info as domainGetJobInfo but in a slightly different format. >> Another difference is that virDomainGetJobStats can also >> retrieve info on the most recently completed job. Though so >> far this is only used in the source node to know if the >> migration has been completed. But because we don't support >> completed jobs we will deliver an error. > This patch, and 7/8, look good - ACK. Nice to see all the > > error : virDomainGetJobInfo:8844 : this function is not supported by the > connection driver: virDomainGetJobInfo > > log entries disappear when doing save, migrate, etc :-). But I'll wait until the > freeze is lifted to push them. Great! And it's also nice to see migration no longer crashing on Openstack, since the monitoring of it relies on these API calls.