Re: [libvirt] Candidate release 2 for libvirt-1.1.0

On 06/28/2013 03:44 AM, Laine Stump wrote: Okay, I pushed the following patch: https://www.redhat.com/archives/libvir-list/2013-June/msg01171.html Can you apply this patch locally to the source tar and re-run your test build to make sure nothing else is broken (since there won't be another rc before release)? If there are still problems, you can find us in #virt on irc.oftc.net. commit a757822233f707c4ed75986f5903e26e40f3cdfa Author: Laine Stump <laine(a)laine.org&gt; Date: Fri Jun 28 04:00:54 2013 -0400 util: fix build error on non-Linux systems Building on FreeBSD had this linker error: /work/a/ports/devel/libvirt/work/libvirt-1.1.0/src/.libs/libvirt.so: undefined reference to `virPCIDeviceAddressParse' This was caused by the new use of virPCIDeviceAddressParse in a portion of virpci.c that wasn't linux-only (in commit 72c029d8). The problem was that virPCIDeviceAddressParse had originally been defined inside #ifdef _linux (because it was only used by another function that was inside the same ifdef). The solution is to move it out to the part of virpci.c that is compiled on all platforms. (Because the portion that was "moved" was 40-50 lines, but only moved up by 15 lines, the diff for the patch is less than non-informative - rather than showing that part that I moved, it shows the bit that was previously before the moved part, and now sits *after* it.)