Re: [libvirt] [PATCH 2/2 v2] qemu: monitor: Make qemuMonitorAddObject more robust against programming errors

On Wed, Jul 04, 2018 at 04:51:04PM +0200, Peter Krempa wrote:

Document and check that @props contains a pointer to a json object and check that both necessary fields are present. Also mark @props as NONNULL.

Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- Diff: - added the not commited fix to add "%s" to the error message so as a syntax-check fix - typo fix in commit message

src/qemu/qemu_monitor.c | 23 +++++++++++++++++------ src/qemu/qemu_monitor.h | 3 ++- 2 files changed, 19 insertions(+), 7 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano