Re: [libvirt] [PATCH v4 38/42] remote: open secondary drivers via remote driver if needed

8 Aug 2019


      On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote:
...
+++ b/src/remote/remote_daemon_dispatch.c
@@ -2077,6 +2105,9 @@ remoteDispatchConnectOpen(virNetServerPtr server ATTRIBUTE_UNUSED,
     unsigned int flags;
     struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
     int rv = -1;
+#ifdef MODULE_NAME
+    const char *type = NULL;
+#endif /* !MODULE_NAME */
Nit: the comment should read

  /* ! MODULE_NAME */

More occurrences later.

-- 
Andrea Bolognani / Red Hat / Virtualization

    