Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: [...] > > Thanks! > > I'll look into werror/rerror support for usb-storage. It shouldn't be > too hard, though it's strictly speaking a separate problem related to > using -blockdev rather than option deprecation. > > If Peter wants to wait for QEMU support before converting werror/rerror Definitely. I don't want to keep around yet another hack that will satisfy one specific case and then add another capability for it. We should then gate the moving of the feature based on the presence of werror for usb-storage. > to -device, maybe it would make sense to split your patch for v2 so that > geometry and serial can get fixed right away? Yes this can be done right away.