Re: [libvirt] PATCH: 23/25: Add domain events to test driver

On Wed, Jan 14, 2009 at 09:57:26AM +0100, Jim Meyering wrote: > Jim Meyering <jim(a)meyering.net&gt; wrote: > > "Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: > >> On Tue, Jan 13, 2009 at 05:48:12PM +0000, Daniel P. Berrange wrote: > >>> This adds support for the domain events in the test driver. Code > >>> is following the same pattern as the impl in the QEMU driver. > >>> > >>> test.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > >>> 1 file changed, 217 insertions(+), 6 deletions(-) > >> > >> Updated patch to not queue events if no event loop impl is defined > >> (as is common from virsh). This is what was breaking the tests cases > > > > Thanks! > > With that, there's only one failure remaining: > > > > 35) Xen SEXPR-2-XML fv-sound-all -> fv-sound-all ... FAILED > > FAIL: sexpr2xmltest > > In your 25-patch series, the new syntax check rule, > sc_prohibit_nonreentrant (nice!) fails because it finds > lots of uses of strerror. Did I miss a patch? This looks > like the change I would have expected to remove those: No, I forgot to mention there were still many more to remove. The ones I have not dealt with are less critical because they're only used in the logging calls like DEBUG(), rather than app facing virRaiseError calls. A number of these logging calls should be removed (if the errno is already propagated to caller where its reported), or converted into error calls. There'd still be a number of calls to strerror() left though. I didn't do this yet because it'll cause even more conflicts with other peoples work than my patchset already has.