On Fri, Jul 14, 2017 at 10:12:12AM -0400, John Ferlan wrote:
On 07/14/2017 05:28 AM, Erik Skultety wrote:
cleanup: - if (obj) - virNodeDeviceObjUnlock(obj); + virNodeDeviceObjEndAPI(&obj); testDriverUnlock(driver); virNodeDeviceDefFree(def); virObjectUnref(dev); @@ -5596,13 +5595,13 @@ testNodeDeviceDestroy(virNodeDevicePtr dev) * taken, so we have to dup the parent's name and drop the lock * before calling it. We don't need the reference to the object * any more once we have the parent's name. */
Not that this patch would be touching it directly, but ^this commentary is pretty much useless now, since @parent_name is useless in this function, nodeDeviceDestroy doesn't work that way anymore.
Erik
Hmmm, I see said the blind man. Looks like commit id '7ad479d0b' should have removed @parent_name as well.
That should be a separate patch - I can create and add it to the end.
Sure, that was the expected outcome :), judging by a quick look at the hunk only, I don't see a problem having such patch at the beginning of the series, do you hit any merge conflicts?
Erik
Yes multiple... Mainly because I changed the comment. I could add it immediately after this patch without conflicts.
Disregard my comment then and proceed with your proposal. Erik