On Mon, Nov 21, 2016 at 14:11:52 -0500, Jason J. Herne wrote:
From: "Collin L. Walling"
<walling(a)linux.vnet.ibm.com>
On s390 , the host's features are heavily influenced by not only the host
hardware but also by hardware microcode level, host OS version, qemu
version and kvm version. In this environment it does not make sense to
attempt to report exact host details.
Signed-off-by: Jason J. Herne <jjherne(a)linux.vnet.ibm.com>
Signed-off-by: Collin L. Walling <walling(a)linux.vnet.ibm.com>
---
src/cpu/cpu_s390.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/cpu/cpu_s390.c b/src/cpu/cpu_s390.c
index 0073565..2ecbd28 100644
--- a/src/cpu/cpu_s390.c
+++ b/src/cpu/cpu_s390.c
@@ -48,20 +48,15 @@ s390NodeData(virArch arch)
static int
-s390Decode(virCPUDefPtr cpu,
+s390Decode(virCPUDefPtr cpu ATTRIBUTE_UNUSED,
const virCPUData *data ATTRIBUTE_UNUSED,
const char **models ATTRIBUTE_UNUSED,
unsigned int nmodels ATTRIBUTE_UNUSED,
const char *preferred ATTRIBUTE_UNUSED,
unsigned int flags)
{
-
virCheckFlags(VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES, -1);
- if (cpu->model == NULL &&
- VIR_STRDUP(cpu->model, "host") < 0)
- return -1;
-
return 0;
}
I know it's probably my fault since I (IIRC) suggested this function to
do nothing. It should rather just go away completely. And the same
applies to s390NodeData.
Jirka