On Wed, Oct 19, 2016 at 01:14:42PM -0400, Cole Robinson wrote:
On 10/03/2016 11:49 AM, Daniel P. Berrange wrote:
This series lets apps enabled UEFI for a guest by simply doing
<loader firmware='uefi'/>
with the other (existing) attributes being auto-filled with correct QEMU specific defaults.
Wasn't clear from the commit messages, but just listing explicitly that after these patches the secboot firmware can be selected with:
<loader firmware='uefi' secure='on'/>
correct?
Yeah, that should work.
I think from virt-manager's perspective this is all sufficient, though we may continue to use the old method since it allows us to list multiple rom+nvram pairs if they exist (like system packages vs the upstream binaries). But certainly I think this interface is what tools like oz will want, to simplify the 'just give me uefi' case
Still though, the ./configure option isn't very flexible and is getting pretty unwieldy. I figure at some point we are going to need to do something akin to gerd's suggested /etc/libvirt/firmware.d
https://www.redhat.com/archives/virt-tools-list/2014-September/msg00145.html
This matches up with Rich Jones' request from libguestfs POV - I think its really a QEMU level config rather than libvirt though, eg /etc/qemu material Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|