Re: [libvirt] [jenkins-ci PATCH] hosts_vars: drop virt-viewer from platforms with old spice-gtk

On Mon, 2018-07-30 at 10:04 +0100, Daniel P. Berrangé wrote: > git master requires spice-gtk >= 0.35 > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > --- > guests/host_vars/libvirt-centos-7/main.yml | 1 - > guests/host_vars/libvirt-debian-8/main.yml | 1 - > guests/host_vars/libvirt-debian-9/main.yml | 1 - > guests/host_vars/libvirt-debian-sid/main.yml | 1 - > guests/host_vars/libvirt-fedora-27/main.yml | 1 - > guests/host_vars/libvirt-freebsd-10/main.yml | 1 - > guests/host_vars/libvirt-freebsd-11/main.yml | 1 - > guests/host_vars/libvirt-freebsd-current/main.yml | 1 - > guests/host_vars/libvirt-ubuntu-14/main.yml | 1 - > guests/host_vars/libvirt-ubuntu-16/main.yml | 1 - > guests/host_vars/libvirt-ubuntu-18/main.yml | 1 - > 11 files changed, 11 deletions(-) All FreeBSD versions have 0.35, so they shouldn't be dropped; Debian Sid is still on 0.34, but I expect it will get 0.35 at some point in the not-too-distant future so I wouldn't touch that either, since it doesn't affect CentOS CI either way. More importantly: do we really want to stop building virt-viewer entirely on those platform just because a recent enough spice-gtk version is not available? Building without spice support still provides some amount of coverage (eg. VNC support), and the builds themselves don't fail, so I don't really see the upside of merging this. My suggestion would be to just disable the virt-viewer-master-rpm job on Fedora 27 and CentOS 7 and call it a day.