Re: [Libvir] Re: PATCH 1/2: Qemu feature reporting
On Tue, Jul 24, 2007 at 10:31:10AM -0700, David Lutterkort wrote:
This patch lets the qemu/kvm drivers report features for i686 and
x86_64. The output is table-driven, like the rest of the capability
generation. That should make it easy to report additional features for
other arches (which I know zip about)
Looks fine to me, except:
+ r = virBufferAdd(xml, "\
+ <pae/>\n", -1);
I really can't understand what's the point of doing the indentation by
cutting in the string parameter, I would really fix those before applying.
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/