Re: [libvirt] [PATCH v3] Makefile: Fix parallel build after Xen-xl parser introduction
On 01/08/2015 12:56 AM, Eric Blake wrote:
On 01/07/2015 02:43 PM, Eric Blake wrote:
> CC xenconfig/libvirt_xenconfig_la-xen_xl.lo
> ../../src/xenconfig/xen_xl.c:29:25: fatal error: xen_xl_disk.h: No such
> file or directory
> #include "xen_xl_disk.h"
> ^
> compilation terminated.
> CC xenconfig/libvirt_xenxldiskparser_la-xen_xl_disk.lo
>
> but that may be an issue with me starting from a dirty build (make has
> the annoying habit of treating a target as up-to-date if the file exists
> in srcdir, even if you have rewritten the makefile to generate the file
> only into builddir). I'll try again from a fresh clone.
It appears I hit a separate issue, and that your builds don't have
xenconfig enabled while mine do. I've posted an independent patch for
the VPATH issue I was seeing, and am back to investigating your patch (I
still think it would be better as two parts - code motion, then fixing
semantics).
I'm OK with splitting the patch into two parts.
Is you wrote in the previous mail this patch ensures that the generated
files are included in tarball (which means generated into srcdir) and
I'm building with xenconfig because I have enabled xen, xenapi and libxl.
This patch works for me for VPATH and also non VPATH builds and I've
also tested creating tarball and building from that tarball and it works.
Thanks for the review and I'll send v4 with two patches.
Pavel