Re: [libvirt] [PATCH] util: json: Remove yajl bits from virJSONValueToStr
On Tue, Apr 03, 2018 at 12:23:13 +0100, Daniel Berrange wrote:
On Sat, Mar 31, 2018 at 11:01:15AM +0200, Peter Krempa wrote:
> Rather than depending on yajl bits for creating the JSON structure
> replace it by few virBuffer bits. This will make the JSON formatter
> libary agnostic.
I don't think this is a good idea as it means we have to reinvent the
wheel to ensure that we are correctly formatting & escaping JSON. This
patch gets escaping wrong which illustrates the point :-(
It has also discarded the utf8 validation that the old code did.
Fair enough. I honestly only cared about the values which we
encountered.
What triggered me to send this patch was, that the proposal to add
another library added yet another place where virJSONValues were
converted to some internal type back and forth, which seems utterly
inefficient.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)