Re: [libvirt] PATCH: 16/25: Fix GNULIB warnings on Mingw
On Fri, Jan 16, 2009 at 12:14:51PM +0100, Jim Meyering wrote:
"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
> The GNULIB Makefile.am doesn't set any particular compiler warning
> flags in the belief that upstream GNULIB developers sort out all
> warnings before committing their code. This is reasonable for builds
> on mainstream Linux platforms, but MinGW builds of GNULIB don't
> have nearly the same level of testing. So This patch adds the libvirt
> $(WARN_CFLAGS) to the gnulib Makefile.am and then fixes the problems
> this showed up. Nothing of consequence really. Leave it upto gnulib
> developers whether its worth fixing these.
>
> Makefile.am | 2
> gettimeofday.c | 5 +-
> ioctl.c | 1
> poll.c | 4 -
> strerror.c | 128 ++++++++++++++++++++++++++++-----------------------------
I've dealt with the poll.c problems upstream.
1) Your patch to remove unused var decls
2) added a pragma to avoid the warning about the unsigned_var < 0 tests
All of this looks fine to commit here.
I've posted an adjusted strerror.c change upstream,
without so many casts.
Dan, what warning does the ioctl one fix?
Same for gettimeofday.
Here's the full set of warnings I got
gettimeofday.c: In function 'rpl_localtime':
gettimeofday.c:54: warning: nested extern declaration of 'localtime'
ioctl.c:32: warning: no previous prototype for 'rpl_ioctl'
poll.c: In function 'rpl_poll':
poll.c:411: warning: comparison of unsigned expression < 0 is always false
poll.c:429: warning: unused variable 'optlen'
strerror.c: In function 'rpl_strerror':
strerror.c:48: warning: return discards qualifiers from pointer target type
strerror.c:54: warning: return discards qualifiers from pointer target type
strerror.c:56: warning: return discards qualifiers from pointer target type
strerror.c:58: warning: return discards qualifiers from pointer target type
strerror.c:60: warning: return discards qualifiers from pointer target type
[snip more strerror]
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|