On 04.03.2015 13:34, Christophe Fergeau wrote:
On Wed, Mar 04, 2015 at 10:50:57AM +0100, Michal Privoznik wrote:
This test is meant for adding CDROM, floppy and disk to a domain. For now, each method has _file and _device variant, which are tested for now.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> ---
Funny, when reviewing Chritophe's patches, I've found one forgotten branch too.
libvirt-designer/test-designer-domain.c | 101 ++++++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+)
diff --git a/libvirt-designer/test-designer-domain.c b/libvirt-designer/test-designer-domain.c index bbd5a28..90f7e68 100644 --- a/libvirt-designer/test-designer-domain.c +++ b/libvirt-designer/test-designer-domain.c
+static void test_domain_machine_simple_disk_setup(GVirDesignerDomain **design, gconstpointer opaque) +{ + GError *error = NULL; + GVirConfigDomainDisk *disk; + OsinfoOs *os = osinfo_os_new("http://myoperatingsystem/amazing/4.2"); + OsinfoDb *db = osinfo_db_new(); + OsinfoPlatform *platform = osinfo_platform_new("http://myhypervisor.org/awesome/6.6.6"); + GVirConfigCapabilities *caps = gvir_config_capabilities_new_from_xml(capsqemuxml, NULL); + + *design = gvir_designer_domain_new(db, os, platform, caps);
You could calll test_domain_machine_setup() here to save a bit of typing/c&p
Awesome!
ACK without or with that change.
Changed and pushed. Thanks. Michal