On 11/15/2013 04:20 AM, Li Zhang wrote:
On 2013年11月14日 18:02, Ján Tomko wrote:
On 10/28/2013 10:20 AM, Shivaprasad G Bhat wrote:
The bus type IDE being enum Zero, the bus type on pseries system appears as IDE for all the disk types. Pseries platform needs this to appear as SCSI instead of IDE.
Signed-off-by: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> --- src/qemu/qemu_domain.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
... This would also affect XML parsing, as these PostParse functions are called when parsing the XML too, not just when doing a XML->native translation.
This also affect all the disks specified on the command line. You shouldn't assume the disk is SCSI when IDE was explicitly specified.
This patch is to parse "-hda" as SCSI device type because Power doesn't support IDE device. I am not sure whether it's necessary to keep IDE device type for Power in libvirt. Currently, QEMU set "-hda" as SCSI for Power platform.
Yes, since QEMU treats it as SCSI, we could do the same for -hdX. I meant that we shouldn't correct command line like -device ide-cd,drive=ddd,bus=ide.0 to SCSI. But it seems domxml-to-native can't even parse the command line libvirt outputs for disks at the moment: error: internal error: missing index/unit/bus parameter in drive 'file=/var/iso/f19.iso,if=none,id=drive-ide0-1-0,readonly=on,format=raw' Jan