Re: [libvirt] [PATCH v2] virsh domxml-from-native to treat SCSI as the bus type for pseries by default

On 2013年11月14日 18:02, Ján Tomko wrote: > On 10/28/2013 10:20 AM, Shivaprasad G Bhat wrote: >> The bus type IDE being enum Zero, the bus type on pseries system appears as >> IDE for all the disk types. Pseries platform needs this to appear as SCSI >> instead of IDE. >> >> Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com&gt; >> --- >> src/qemu/qemu_domain.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >>

> This would also affect XML parsing, as these PostParse functions are called > when parsing the XML too, not just when doing a XML->native translation. > > This also affect all the disks specified on the command line. You shouldn't > assume the disk is SCSI when IDE was explicitly specified. This patch is to parse "-hda" as SCSI device type because Power doesn't support IDE device. I am not sure whether it's necessary to keep IDE device type for Power in libvirt. Currently, QEMU set "-hda" as SCSI for Power platform.