Re: [libvirt] [PATCH] build: Remove --with-xml-catalog-file option
On Fri, Mar 23, 2018 at 09:36:34PM +0100, Rainer Müller wrote:
After validation against XHTML 1.0 was dropped in f802c9de0,
the XML_CATALOG_FILE is not in use anymore. Therefore the checks in
configure can be removed.
---
configure.ac | 3 ---
m4/virt-xml-catalog.m4 | 33 ---------------------------------
2 files changed, 36 deletions(-)
delete mode 100644 m4/virt-xml-catalog.m4
Nice diffstat!
However, as said in our HACKING guide, general tip #6:
https://libvirt.org/hacking.html#patches
we require a sign-off for every patch.
Could you please provide one to certify that you deleted all those
useless lines of code in compliance with DCO:
https://developercertificate.org/
Thanks,
Jan
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)