On 1/25/19 11:46 AM, Kevin Wolf wrote:
The vendor specific designator in the Device Identification VPD page has two problems:
1. It defaults to the BlockBackend name (-drive id=...), which everyone expected to be a host detail that the guest never sees
2. With -blockdev based setups it defaults to an empty string; if this default is used with more than one disk, the guest OS will interpret this as a single multipath disk.
We can address problem 2 immediately, and start running the deprecation clock for problem 1.
Related bug reports: https://bugzilla.redhat.com/show_bug.cgi?id=1669446 https://bugzilla.redhat.com/show_bug.cgi?id=1668248
Kevin Wolf (3): scsi-disk: Don't use empty string as device id scsi-disk: Add device_id property scsi-disk: Deprecate device_id fallback to BlockBackend name
Reviewed-by: Eric Blake <eblake@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org