Re: [libvirt] [PATCH 2/4] Audit VM start/stop/suspend/resume

On Thu, Oct 14, 2010 at 04:09:41PM +0200, Daniel Veillard wrote: > On Tue, Oct 12, 2010 at 06:32:16PM +0100, Daniel P. Berrange wrote: > > From: Miloslav Trmač <mitr(a)redhat.com&gt; > > > > Most operations are audited at the libvirtd level; auditing in > > src/libvirt.c would result in two audit entries per operation (one in > > the client, one in libvirtd). > > > > The only exception is a domain stopping of its own will (e.g. because > > the user clicks on "shutdown" inside the interface). There can often be > > no client connected at the time the domain stops, so libvirtd does not > > have any virConnectPtr object on which to attach an event watch. This > > patch therefore adds auditing directly inside the qemu driver (other > > drivers are not supported). > > Looks fine but using base64 transfer encoding: > > Content-Type: text/plain; charset="utf-8" > Content-Transfer-Encoding: base64 > Sender: libvir-list-bounces(a)redhat.com > Errors-To: libvir-list-bounces(a)redhat.com > Status: RO > > RnJvbTogTWlsb3NsYXYgVHJtYcSNIDxtaXRyQHJlZGhhdC5jb20+CgpNb3N0IG9wZXJhdGlvbnMg > YXJlIGF1ZGl0ZWQgYXQgdGhlIGxpYnZpcnRkIGxldmVsOyBhdWRpdGluZyBpbgpzcmMvbGlidmly > > makes applying the patch way harder than it should. I wonder why mails > 2, 3 and 4 got the problem nut not 1/4 .... puzzled, could you have a > look ? I just used git send-email as normal. It is probably the magic characters in Miloslav's name that convinced git to change to a diffrent content encoding