Re: [libvirt] [PATCH 4/8] conf: domaincaps: Add 'iothreads' to the features section

On Thu, Nov 14, 2019 at 12:55:40 +0100, Ján Tomko wrote: > On Wed, Nov 13, 2019 at 05:05:22PM +0100, Peter Krempa wrote: > > Historically iothreads were the first feature and thus didn't have it's > > own section. Add them to <features> for consistency with other features. > > > > I'm not convinced duplicating this is a good idea - apps looking into > the <features> element for iothread support would only find it with > libvirt new enough to have it there and miss out on iothread support > with older libvirt. I certainly can keep 'iothreads' separate. I'm definitely not going to add an special case into the formatter to avoid formatting it there. Also to be fair I'm not sure whether it's worth caring about the outlined scenario. If an APP looks for iothreads in <features> it should not be used with older libvirt than the one where it was added. At any rate, I can drop this patch and keep the iothreads stuff separate.