Re: [libvirt] [PATCH v3 5/5] blockcommit: turn on active commit

On 06/11/14 18:27, Eric Blake wrote: > With this in place, I can (finally!) now do: > > virsh blockcommit $dom vda --shallow --wait --verbose --pivot >

> - /* FIXME: qemu 2.0 supports active commit, but as a two-stage > - * process; qemu 2.1 is further improving active commit. We need > - * to start supporting it in libvirt. */ > if (topSource == disk->src) { > /* We assume that no one will backport qemu 2.0 active commit > * to an earlier qemu without also backporting the block job > - * ready event; but this makes sure of that fact */ > + * ready event; but this makes sure of that fact. > + * > + * XXX Also need to check other capability bit(s): qemu 1.7 > + * supports async blockjob but not active commit; and qemu 2.0 > + * active commit misbehaves on 0-byte file. */ How about tying the support to qemu 2.1 if it makes things easier? I don't see any problem with supporting stuff from later-than-introduced versions. The only question that remains is whether there's anything relevant to trigger the capability of.