On 03/08/2010 05:29 PM, Eric Blake wrote:
On 03/05/2010 12:06 PM, Chris Lalancette wrote:
The current code for "nodeinfo" is pretty naive about socket and thread information. To determine the sockets, it just takes the number of cpus and divides by the number of cores. For the thread count, it always sets it to 1. With more recent Intel machines, however, hyperthreading is again an option, meaning that these heuristics no longer work and give bogus numbers.
<snip>
+ +static int parse_socket(int cpu) +{
Several tools (such as ctag, or even more simply, 'git grep "^func"') work better if all function implementations are listed with split lines, such that the function name starts at the first column:
I've made the cleanups you suggested except for this one. I don't know what the policy will be, but I'll leave it for now and we can do a more global cleanup when we agree on something. -- Chris Lalancette