On 03/05/2010 10:41 AM, Dave Allan wrote:
On 03/04/2010 07:49 PM, Ed Swierk wrote:
> On Thu, Mar 4, 2010 at 10:31 AM, Dave Allan<dallan(a)redhat.com> wrote:
>> I reworked udevSetupSystemDev into this style (which also fixes the
>> bug you
>> pointed out that it didn't properly free resources on error). The patch
>> also makes failure to find DMI data non-fatal.
>
> Your patch works fine. Thanks.
>
> Acked-by: Ed Swierk<eswierk(a)aristanetworks.com>
Thanks for the ACK; anybody else willing to provide the second?
>From 23526641083527139548c68b4637bae8350d2f98 Mon Sep 17 00:00:00
2001
From: David Allan <dallan(a)redhat.com>
Date: Thu, 4 Mar 2010 13:17:24 -0500
Subject: [PATCH 1/1] Free resources on error in udev startup
* The udev driver didn't properly free resources that it allocates when setting up
the 'computer' device in the error case.
I didn't see this one in the repository yet; but if it helps to have
another review via code inspection, I've read through your patch and it
looks like a sane split in functionality. Therefore:
ACK.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org