On Thu, Mar 10, 2016 at 05:54:03AM +0100, Martin Kletzander wrote:
We were using parenteses for grouping admin|remote even though we didn't
parentheses
need to capture what's in it. That caused some changes to be grater
greater
than needed and, to be honest, some confusion as well. Let's use it as it should be used. It'll also make future changes more consistent.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- src/rpc/gendispatch.pl | 118 ++++++++++++++++++++++++------------------------- 1 file changed, 59 insertions(+), 59 deletions(-)
@@ -899,7 +899,7 @@ elsif ($mode eq "server") {
if ($single_ret_as_list) { print " if (args->$single_ret_list_max_var > $single_ret_list_max_define) {\n"; - print " virReportError(VIR_ERR_INTERNAL_ERROR,\n"; + print " virReportError(VIR_ERR_RPC,\n"; print " \"%s\", _(\"max$single_ret_list_name > $single_ret_list_max_define\"));\n"; print " goto cleanup;\n"; print " }\n";
ACK minus this unrelated hunk. Jan