On Fri, Mar 21, 2008 at 02:14:38PM -0700, Dave Leskovec wrote:
Daniel P. Berrange wrote:
The following patches make the driver properly integrate with the stateful driver APIs. It also changes the config files to be named by on VM name instead of UUID, since this is what the QEMU driver does & its more user friendly. It also adds the CLONE_XXX constants since they have not yet been added to the libc sched.h file. IMHO we should enable the driver by default, since it can already probe for availability at runtime. Finally it also fixes a typo where it wrote 'linuxcontainer' as the domain type in the config file instead of 'lxc'.
Thanks, this looks great.
Back when I posted the first pass of these patches, you mentioned it should be defaulted to enabled only on Linux. I'm not an autoconf expert (or intermediate for that matter). How do we default the enabled parm based on the host os?
Hum, maybe in configure.in if test "$with_lxc" = "yes" ; then could be tweaked to use the "`uname`" = "Linux" condition too. But I don't know if the AC_ARG_WITH(lxc, [ --with-lxc add Linux Container support (off)],[],[with_lxc=no]) can be enclosed in a similar if test, probably worth trying Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/