Re: [libvirt] [PATCH 2/3] qemu: add two qemu caps for lsi and virtio-scsi SCSI controllers
On 08/08/2012 07:03 AM, Eric Blake wrote:
On 08/07/2012 03:55 PM, Eric Blake wrote:
> On 08/07/2012 11:21 AM, Guannan Ren wrote:
>> Rename qemuDefaultScsiControllerModel to qemuCheckScsiControllerModel.
>> When scsi model is given explicitly in XML(model > 0) checking if the
>> underlying QEMU supports it or not first, raise an error on checking
>> failure.
>> When the model is not given(mode <= 0), return LSI by default, if
>> the QEMU doesn't support it, raise an error.
> ACK.
This patch introduces even more testsuite breaks than 1/3. Please fold
the rest of 3/3 into this patch, and when you push, you should have just
two patches, both with testsuite improvements, and where both patches in
isolation pass 'make check'.
And don't forget the /VIRIO/VIRTIO/ spelling fix.
Thanks for the review.
Finally, it comes to two patches with separate fixed testcase
squashed in
, each of them could pass 'make check'.
The spelling is fixed too.
I choose keeping the format of switch statement code. The *model
could be
value 0 (VIR_DOMAIN_CONTROLLER_MODEL_SCSI_AUTO)
or value -1
model = virXMLPropString(node, "model");
if (!model)
def->model = -1;
Pushed.
Guannan