Re: [libvirt] [libvirt-glib PATCHv2 4/5] gobject: Add wrapper for virNetworkDHCPLease

On Tue, Jun 30, 2015 at 01:25:28PM +0100, Zeeshan Ali (Khattak) wrote: > On Tue, Jun 30, 2015 at 12:41 PM, Christophe Fergeau > <cfergeau(a)redhat.com&gt; wrote: > > Hey, > > > > Looks good to me, I'd name the type GVirNetworkDhcpLease rather than > > GVirNetworkDHCPLease, this is consistent with > > GVirConfigCapabilitiesCpuModel (and not CPUModel). > > Hm.. I was trying to keep it consistent with the underlying > 'virNetworkDHCPLease'. I agree - IMHO acronyms should always be capitalized in our APIs - use of Cpu is a bug (which we can't fix), but we should not add more of such bugs. Likewise MAC, rather than Mac