On 08/31/2012 07:57 AM, Daniel P. Berrange wrote:
some more generic name. eg
virNodeSetMemorySharingParameters
likewise for all the enum/constant names.
For that matter, why can't we reuse the existing virDomainSetMemoryParameters() for the enum/constants? That is, whether or not to use ksm is a memory parameter.
Actually this is a host level action. There is a separate non-upstreamed patch which lets us control whether KSM is used per-guest, which is waiting for a fix to QEMU
Oh, I missed virNode vs. virDomain. Still, consistent naming argues for virNodeSetMemoryParameters (not MemorySharingParameters), so that we can add future MemoryParameters unrelated to sharing. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org