On 09/14/2017 02:50 PM, Daniel P. Berrange wrote:
The sanity test check aims to ensure that every function listed in the Python code maps to a corresponding C function. The Sparse send/recv methods are special though - we're never calling the corresponding C APIs, instead we have a pure python impl.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- sanitytest.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sanitytest.py b/sanitytest.py index deec200..a5cb01b 100644 --- a/sanitytest.py +++ b/sanitytest.py @@ -351,7 +351,8 @@ for klass in gotfunctions: for func in sorted(gotfunctions[klass]): # These are pure python methods with no C APi if func in ["connect", "getConnect", "domain", "getDomain", - "virEventInvokeFreeCallback"]: + "virEventInvokeFreeCallback", + "sparseRecvAll", "sparseSendAll"]: continue
key = "%s.%s" % (klass, func)
Looks good to me. I tested it with libvirt v3.1.0 since with libvirt-python commit id d7e1c97 the sanitytest failed during build. This means all libvirt-python versions starting from 3.4.0 are hit by this bug. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294