On Fri, Apr 02, 2010 at 04:48:36PM -0400, Laine Stump wrote:
On 04/02/2010 04:26 PM, Eric Blake wrote:
On 04/02/2010 01:56 PM, Daniel Veillard wrote:
+static int +qemuDomainManagedSave(virDomainPtr dom, + unsigned int flags ATTRIBUTE_UNUSED) No - for future compability, we NEED to check that flags==0 or fail now. Otherwise, a future version, where flags has meaning, will mistakenly think that our older version can honor those flags.
That makes sense, but there's a lot of precedence to the contrary already in the code:
find . -name \*.c | xargs grep "flags ATTRIBUTE_UNUSED" | wc 155 832 14106
(some of these are probably false positives, but still...)
Sounds like you're volunteering for a global cleanup ;-)
The problem is that the cleanup could break existing behaviour, so I would be quite cautious about it and really look on a case by case basis. But for new interfaces, yes we should do this, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/