Re: [Libvir] [PATCH][RFC] Add --keymap option to virt-install

On Tue, Mar 06, 2007 at 10:00:08PM +0900, Takahashi Tomohiro wrote: > I would like to add --keymap option to virt-install in order to set up > jp106 keymap. Because I can't use jp106 keyboard. So, I made a patch > (notes:It relates python-virtinst) > > Usage: virt-install --keymap=ja > > I confirmed that I can use jp106 keyboard on HVM domain. > But didn't confirm PV domain. > > Please give me an advice, if you have it. I've been expecting someone to send this patch for quite a while :-) It all looks good to me, although all my keyboards are US english so my own testing will be limited to making sure the keymap gets passed through to the QEMU daemon correctly. For paravirt, I think you need to have Xen 3.0.5 to use keymap, but I'll double check that and then apply this. > @@ -1903,6 +1907,8 @@ virConfPtr xenXMParseXMLToConfig(virConn > len += 11 + strlen((const char*)vnclisten); > if (vncpasswd) > len += 11 + strlen((const char*)vncpasswd); > + if (keymap) > + len += 11 + strlen((const char*)keymap); > if ((val = malloc(len)) != NULL) { > strcpy(val, "type=vnc"); > if (vncunused) { A minor bug - the length is only 8, not 11, but I'll fix that when I commit, so don't worry about sending an updated patch.