On 11/11/2018 08:59 PM, Chris Venteicher wrote:
s/cmd/proc/ in process code imported from qemu_capabilities.
No functionality is changed. Just variable renaming.
Process code imported from qemu_capabilities was oriented around starting a process to issue a single QMP command.
Future usecases (ex. baseline, compare) expect to use a single process to issue multiple different QMP commands.
This patch changes the variable naming from cmd to proc to put focus on the process being maintained to issue commands.
Signed-off-by: Chris Venteicher <cventeic@redhat.com> --- src/qemu/qemu_capabilities.c | 14 ++-- src/qemu/qemu_process.c | 140 +++++++++++++++++------------------ src/qemu/qemu_process.h | 6 +- 3 files changed, 80 insertions(+), 80 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index f6d97648ce..1ea63000e2 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -4219,7 +4219,7 @@ virQEMUCapsInitQMP(virQEMUCapsPtr qemuCaps, gid_t runGid, char **qmperr) { - qemuProcessPtr cmd = NULL; + qemuProcessPtr proc = NULL; int ret = -1; int rc;
This is actually the place where the problem I've raised in 02/22 should be addressed. s/cmd/proc/ should happen here. Michal