Re: [libvirt] [PATCH] maint: increase stack frame size limit
On 05/08/2015 12:23 AM, Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
> Roman Bogorodskiy wrote:
>
>> Currently the stack frame size limit is set to 4096 and it started to
>> cause an error like this:
>>
>> virshtest.c:253:1: error: stack frame size of 5512 bytes in function
>> 'mymain' [-Werror,-Wframe-larger-than=]
>> mymain(void)
>> ^
>> 1 error generated.
>>
>> Increase it to 6144.
>
> Worth to mention that it's started to show up after updating to clang
> 3.6.
Any comments on this?
Have you reported a possible clang regression bug to the clang folks?
Or is the new clang version the first one to support what was originally
only gcc's -Wframe-larger-than? At any rate, why does clang require a
larger stack than gcc? It sounds like in addition to fixing the
virshtest.c file to quit stack-allocating such a large amount of space,
that you should also be letting the clang compiler folks know about
their weakness.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)