Re: [libvirt-jenkins-ci PATCH 7/7] lcitool: Create and expose ccache wrappers
On Mon, 2020-03-30 at 12:52 +0100, Daniel P. Berrangé wrote:
On Fri, Mar 27, 2020 at 08:34:59PM +0100, Andrea Bolognani wrote:
> sys.stdout.write(textwrap.dedent("""
> ENV LANG "en_US.UTF-8"
> + ENV PATH "/usr/local/share/ccache-wrappers:$PATH"
I don't think we should do this though.
When doing local container builds "make ci-build@BLAH" the container
content is throwaway, so using ccache is adding extra I/O to store
the cache arifacts but will not speed up compile as the cache will
always be initially empty.
I think we only want to set $PATH in the .gitlab-ci.yml file where
we have explicitly provided a persistent cache to use.
Sounds reasonable.
We could still expose the path as something like
ENV CCACHE_WRAPPERSDIR "/usr/local/share/ccache-wrappers"
so that the CI rules would be able to do
- export PATH="$CCACHE_WRAPPERSDIR:$PATH"
instead of hardcoding the exact path. What do you think?
--
Andrea Bolognani / Red Hat / Virtualization