Re: [libvirt] PATCH: Fix misc bugs in QEMU ARGV -> XML convertor

On Thu, May 28, 2009 at 10:47:14AM +0100, Daniel P. Berrange wrote:

Having just tried out the QEMU ARGV -> XML convertor on a random set of args posted on the mailing list I found a few bugs. It didn't cope with a -net arg without a vlan=XX option set - this should assume vlan=0 if not set. It didn't cope with quoting of args with spaces in them. It finally did not generate a random UUID or MAC address if omitted.

Looks fine, would be even better if a couple of extra example could exercise the code :-) ACK Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/