On 09/04/2014 10:11 AM, Peter Krempa wrote:
On 08/31/14 06:02, Eric Blake wrote:
While reviewing the new virDomainBlockCopy API, Peter Krempa pointed out that our existing design of using MiB/s for block job bandwidth is rather coarse, especially since qemu tracks it in bytes/s; so virDomainBlockCopy only accepts bytes/s. But once the new API is implemented for qemu, we will be in the situation where it is possible to set a value that cannot be accurately reflected back to the user, because the existing virDomainGetBlockJobInfo defaults to the coarser units.
ACK. I presume virsh will be modified later in the series.
Indeed. I'm still working on the virsh modifications for setting bandwidth in a different scale, but 9/18 was the modification for getting in smarter units. This one is now pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org